Post by Adam R. Maxwell I fixed or worked around a bunch of warnings in Xcode 4, some of which were code bugs. Should I check those in or send a diff?
Are there a lot of changes? You can check them in if you want to.
A bunch of them are stupid clang warnings due to stronger type checking. Unfortunately, the noise from those makes it hard to see real problems :/.
Post by Christiaan Hofman Christiaan ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ skim-app-develop mailing list https://lists.sourceforge.net/lists/listinfo/skim-app-develop
Okay, done. The remainder are bound up in other files that I've modified, and don't have time to separate out now. I've committed the really tedious ones, though.
I think it also complains about strings file encodings, and the other big one is that the NSPasteboard protocols aren't fully implemented on PDFAnnotation. Oh, and the cast (id)super should be removed.
Post by Adam R. Maxwell Okay, done. The remainder are bound up in other files that I've modified, and don't have time to separate out now. I've committed the really tedious ones, though.
I already changed some things in return (like changing the "tags" property to NSArray consistently, as that's whatr we set it to through the property.)
I don't really like the typing changes to the delegate/dataSource methods. Isn't that wrong by itself? If it were requried methods I think it would complain about missing methods.